Update how formatters are registered, allowing the addition of custom formatter #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… formatter in a easy way
ashkulz
requested changes
Oct 23, 2023
There was a problem hiding this comment.
Looks very good, @emilio2hd! Just a few minor changes and we're good to go.
Change formatter_klass to be a required parameter
ashkulz
approved these changes
Oct 24, 2023
ashkulz
approved these changes
Oct 27, 2023
|
Thanks for the contribution, @emilio2hd! |
|
Thank for the guidance and accepting the contribution! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same Devise logic to registry the formatters, instead of using a frozen const.
Please check #451 for more context